rclcpp::shutdown should not be called before LifecycleNode dtor.#2527
Merged
fujitatomoya merged 1 commit intorollingfrom May 24, 2024
Merged
rclcpp::shutdown should not be called before LifecycleNode dtor.#2527fujitatomoya merged 1 commit intorollingfrom
fujitatomoya merged 1 commit intorollingfrom
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
commented
May 11, 2024
Collaborator
Author
|
@clalancette can you take a look? |
Collaborator
Author
|
|
Collaborator
Author
|
@mjcarroll @alsora i could use review for this. after i have a lgtm, i will start the CI. |
Collaborator
Author
|
CI:
|
Collaborator
Author
|
aarch64 test failures are unrelated, https://ci.ros2.org/job/ci_linux-aarch64/15441/ |
Collaborator
Author
|
@Mergifyio backport humble iron jazzy |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
May 24, 2024
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 22df1d5) # Conflicts: # rclcpp_lifecycle/test/test_lifecycle_publisher.cpp
mergify bot
pushed a commit
that referenced
this pull request
May 24, 2024
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 22df1d5)
mergify bot
pushed a commit
that referenced
this pull request
May 24, 2024
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 22df1d5)
fujitatomoya
added a commit
that referenced
this pull request
May 24, 2024
fujitatomoya
added a commit
that referenced
this pull request
May 24, 2024
fujitatomoya
added a commit
that referenced
this pull request
May 24, 2024
…kport #2527) (#2538) * rclcpp::shutdown should not be called before LifecycleNode dtor. (#2527) Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 22df1d5) # Conflicts: # rclcpp_lifecycle/test/test_lifecycle_publisher.cpp * resolve conflicts. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
address part of #2520