Skip to content

rclcpp::shutdown should not be called before LifecycleNode dtor. (backport #2527)#2538

Merged
fujitatomoya merged 2 commits intohumblefrom
mergify/bp/humble/pr-2527
May 24, 2024
Merged

rclcpp::shutdown should not be called before LifecycleNode dtor. (backport #2527)#2538
fujitatomoya merged 2 commits intohumblefrom
mergify/bp/humble/pr-2527

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented May 24, 2024

address part of #2520


This is an automatic backport of pull request #2527 done by Mergify.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 22df1d5)

# Conflicts:
#	rclcpp_lifecycle/test/test_lifecycle_publisher.cpp
@mergify mergify bot added the conflicts label May 24, 2024
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented May 24, 2024

Cherry-pick of 22df1d5 has failed:

On branch mergify/bp/humble/pr-2527
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 22df1d59.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rclcpp_lifecycle/test/test_lifecycle_publisher.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya force-pushed the mergify/bp/humble/pr-2527 branch from 431fd07 to 281541a Compare May 24, 2024 01:19
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@fujitatomoya
Copy link
Copy Markdown
Collaborator

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit f95ac7c into humble May 24, 2024
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/humble/pr-2527 branch May 24, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant