Implement validity checks for rclcpp::Clock (backport #2040)#2210
Merged
fujitatomoya merged 1 commit intohumblefrom Jun 14, 2023
Merged
Implement validity checks for rclcpp::Clock (backport #2040)#2210fujitatomoya merged 1 commit intohumblefrom
fujitatomoya merged 1 commit intohumblefrom
Conversation
(cherry picked from commit c091fe1)
Contributor
|
Requires the backport for To be merged before this is merged!! |
Collaborator
|
Depends on ros2/rcl#1078 (backports ros2/rcl#1021 to humble) |
fujitatomoya
approved these changes
Jun 13, 2023
Collaborator
|
CI:
|
emersonknapp
approved these changes
Jun 13, 2023
Collaborator
|
@fujitatomoya @methylDragon friendly ping for merge at earliest convenience |
tkimura4
pushed a commit
to tier4/rclcpp
that referenced
this pull request
Aug 17, 2023
tkimura4
added a commit
to tier4/rclcpp
that referenced
this pull request
Aug 17, 2023
…rt 0.15.7 (#3) * Implement validity checks for rclcpp::Clock (ros2#2040) (ros2#2210) (cherry picked from commit c091fe1) Co-authored-by: methylDragon <methylDragon@gmail.com> * rclcpp: check rcl version [humble] Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> --------- Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: methylDragon <methylDragon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2040 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com