Use the correct macro for LifecycleNode::get_fully_qualified_name#2117
Merged
clalancette merged 1 commit intorollingfrom Mar 6, 2023
Merged
Use the correct macro for LifecycleNode::get_fully_qualified_name#2117clalancette merged 1 commit intorollingfrom
clalancette merged 1 commit intorollingfrom
Conversation
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Contributor
Author
|
CI:
|
alsora
approved these changes
Mar 6, 2023
mjcarroll
approved these changes
Mar 6, 2023
fujitatomoya
approved these changes
Mar 6, 2023
Contributor
Author
|
The yellow failure on Windows is unrelated to this, so going ahead and merging. |
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 29, 2023
…s2#2117) Signed-off-by: Chris Lalancette <clalancette@gmail.com>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 29, 2023
…s2#2117) Signed-off-by: Chris Lalancette <clalancette@gmail.com>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
May 3, 2023
…s2#2117) Signed-off-by: Chris Lalancette <clalancette@gmail.com>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
May 3, 2023
…s2#2117) Signed-off-by: Chris Lalancette <clalancette@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this should avoid the warning we are seeing on Windows of "inconsistent dll linkage". This looks like it was introduced by #2115. FYI @mjcarroll @SteveMacenski @fujitatomoya
Warning message for reference: https://ci.ros2.org/view/nightly/job/nightly_win_rel/2610/msbuild/