Skip to content

Fix returning invalid namespace if sub_namespace is empty (backport #1658)#1810

Merged
cottsay merged 1 commit intogalacticfrom
mergify/bp/galactic/pr-1658
Dec 7, 2022
Merged

Fix returning invalid namespace if sub_namespace is empty (backport #1658)#1810
cottsay merged 1 commit intogalacticfrom
mergify/bp/galactic/pr-1658

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Oct 25, 2021

This is an automatic backport of pull request #1658 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

* Create valid effective namespace when sub-namespace is empty

Fix #1656.

Signed-off-by: Markus Hofstaetter <markus.hofstaetter@ait.ac.at>

* Add regression test for effective namespace and empty sub-namespace

Adds regression test for #1656.

Signed-off-by: Markus Hofstaetter <markus.hofstaetter@ait.ac.at>
(cherry picked from commit 3cddb4e)
@fujitatomoya
Copy link
Copy Markdown
Collaborator

CC: @aprotyas

@aprotyas
Copy link
Copy Markdown
Member

CI (build: --packages-up-to test_rclcpp, test: --packages-select rclcpp test_rclcpp)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@cottsay
Copy link
Copy Markdown
Member

cottsay commented Dec 6, 2022

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@cottsay cottsay merged commit 0b60691 into galactic Dec 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/galactic/pr-1658 branch December 7, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants