Address #1423 by moving rosidl_generate_interfaces call#1424
Merged
Conversation
Signed-off-by: Stephen Brawner <brawner@gmail.com>
cottsay
approved these changes
Oct 23, 2020
Contributor
Author
|
Yup, this fixes the issue introduced by #1422 |
brawner
added a commit
that referenced
this pull request
Nov 5, 2020
brawner
added a commit
that referenced
this pull request
Nov 6, 2020
…l_generate_interfaces_call (#1424) (#1437) * Refactor test CMakeLists in prep for benchmarks (#1422) Signed-off-by: Stephen Brawner <brawner@gmail.com> * Address #1423 by moving rosidl_generate_interfaces call (#1424) Signed-off-by: Stephen Brawner <brawner@gmail.com> * Remove rolling-only tests Signed-off-by: Stephen Brawner <brawner@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These interfaces are needed by the test_subscription_topic_statistics test, but somehow generating them at a different scope than where the
rosidl_target_interfacescall occurs doesn't correctly target the libraries.Fixes #1423
Testing
--packages-select rclcppSigned-off-by: Stephen Brawner brawner@gmail.com