Conversation
Signed-off-by: Stephen Brawner <brawner@gmail.com>
cottsay
approved these changes
Nov 5, 2020
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Contributor
Author
|
Building foxy with benchmarks on and testing
|
ahcorde
requested changes
Nov 5, 2020
Contributor
ahcorde
left a comment
There was a problem hiding this comment.
cppcheck is failing in MAC
Contributor
Author
|
It looks like cppcheck just timed out, which we have seen periodically. That timeout is controlled in ament_lint/ament_cppcheck. We should see if that's still a common occurence, but for the sake of making sure all these PRs get in today, I'm going to go ahead with this one. |
Contributor
Author
|
Squash merging, since two commits address issues introduced by the first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I combined these two backports since #1422 introduces a bug and #1424 addresses it. The commit for #1424 had to be adjusted to work in this commit order, since #1424 is later on rolling.