Skip to content

[eloquent backport] Intra-process subscriber should use RMW actual qos. (ros2#913) (#914)#965

Merged
jacobperron merged 1 commit intoeloquentfrom
jacob/backport_914
Jan 17, 2020
Merged

[eloquent backport] Intra-process subscriber should use RMW actual qos. (ros2#913) (#914)#965
jacobperron merged 1 commit intoeloquentfrom
jacob/backport_914

Conversation

@jacobperron
Copy link
Copy Markdown
Member

Backport #914 to Eloquent.

* Intra-process subscriber should use RMW actual qos. (#913)

Signed-off-by: Todd Malsbary <todd.malsbary@intel.com>
@jacobperron jacobperron requested a review from mjcarroll January 17, 2020 21:56
@jacobperron jacobperron merged commit 7ff1b29 into eloquent Jan 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the jacob/backport_914 branch January 17, 2020 22:18
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
* Only check wait_set->impl for NULL pointer.

The previous line already checked wait_set for NULL pointer,
so there is no reason to call rcl_wait_set_is_valid and
recheck that pointer.

* Remove some debug statements from rcl_wait.

While profiling an application, I found that a lot of time was
spent just checking whether a log message should be output
or not based on the current debug level.  None of the individual
calls are expensive, but since rcl_wait is called so often,
it ends up showing up in the profile.

This patch somewhat controversially removes the debug statements
from rcl_wait().  My view on it is that the utility of these
is fairly low (if you ever turned them on, you would be flooded
with information), and the cost is relatively high.  If you
are really debugging this stuff, you can add in your own, more
targeted debug statements or use a debugger.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants