Skip to content

Use rmw_event_type_is_supported in test_qos_event#2761

Merged
ahcorde merged 1 commit intorollingfrom
ahcorde/rolling/rmw_event_type_is_supported
Mar 11, 2025
Merged

Use rmw_event_type_is_supported in test_qos_event#2761
ahcorde merged 1 commit intorollingfrom
ahcorde/rolling/rmw_event_type_is_supported

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Mar 7, 2025

Related with this issue ros2/rmw_zenoh#285. Use the new API in rmw to check if an event is supported

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from Yadunund March 7, 2025 16:30
@ahcorde ahcorde self-assigned this Mar 7, 2025
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI.

Note

depends on ros2/rmw#395

@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 11, 2025

Pulls: #2761
Gist: https://gist.githubusercontent.com/ahcorde/2c27dceb6bd8b984fc96576a12bf3fab/raw/7d338aa6bdf3e6e20269ecd569ac5742b15a36f8/ros2.repos
BUILD args: --packages-up-to rclcpp --packages-above-and-dependencies rclcpp
TEST args: --packages-select rclcpp --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15336

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 9db7fa2 into rolling Mar 11, 2025
2 of 3 checks passed
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 12, 2025

https://github.com/Mergifyio backport jazzy

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 12, 2025

backport jazzy

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Mar 12, 2025
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit 9db7fa2)

# Conflicts:
#	rclcpp/test/rclcpp/test_qos_event.cpp
ahcorde pushed a commit that referenced this pull request Mar 12, 2025
…2766)

* Use rmw_event_type_is_supported in test_qos_event (#2761)

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit 9db7fa2)
jplapp pushed a commit to pixel-robotics/rclcpp that referenced this pull request Apr 9, 2025
ros2#2766)

* Use rmw_event_type_is_supported in test_qos_event (ros2#2761)

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit 9db7fa2)
mojomex pushed a commit to mojomex/rclcpp that referenced this pull request Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants