Skip to content

Use rmw_event_type_is_supported in test_qos_event (backport #2761)#2766

Merged
ahcorde merged 2 commits intojazzyfrom
mergify/bp/jazzy/pr-2761
Mar 12, 2025
Merged

Use rmw_event_type_is_supported in test_qos_event (backport #2761)#2766
ahcorde merged 2 commits intojazzyfrom
mergify/bp/jazzy/pr-2761

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Mar 12, 2025

Related with this issue ros2/rmw_zenoh#285. Use the new API in rmw to check if an event is supported

This is an automatic backport of pull request #2761 done by Mergify.

@ahcorde @mergify
Use rmw_event_type_is_supported in test_qos_event (#2761)
2985777 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit 9db7fa2)

# Conflicts:
#	rclcpp/test/rclcpp/test_qos_event.cpp
@mergify mergify bot added the conflicts label Mar 12, 2025
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Mar 12, 2025

Cherry-pick of 9db7fa2 has failed:

On branch mergify/bp/jazzy/pr-2761
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit 9db7fa2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rclcpp/test/rclcpp/test_qos_event.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Mar 12, 2025
Merged
@ahcorde
Fixed merge
aabc2b2 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Mar 12, 2025 •
edited
Loading

Pulls: #2766
Gist: https://gist.githubusercontent.com/ahcorde/075ece9b50f258aee48c1b027a0abeee/raw/852ccd836d12ade5d63397c07e8fd6bacb4e0eb1/ros2.repos
BUILD args: --packages-up-to rclcpp --packages-above-and-dependencies rclcpp
TEST args: --packages-select rclcpp --packages-above rclcpp
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15350

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 9c7e591 into jazzy Mar 12, 2025
2 checks passed
jplapp pushed a commit to pixel-robotics/rclcpp that referenced this pull request Apr 9, 2025
@mergify @jplapp
Use rmw_event_type_is_supported in test_qos_event (backport ros2#2761) (
e655b87 
ros2#2766)

* Use rmw_event_type_is_supported in test_qos_event (ros2#2761)

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit 9db7fa2)
@MichaelOrlov MichaelOrlov deleted the mergify/bp/jazzy/pr-2761 branch July 29, 2025 17:53
mojomex pushed a commit to mojomex/rclcpp that referenced this pull request Feb 16, 2026
@mergify @mojomex
Use rmw_event_type_is_supported in test_qos_event (backport ros2#2761) (
e0e2ce9 
ros2#2766)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

No one assigned

Labels

conflicts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ahcorde