set QoS History KEEP_ALL explicitly for statistics publisher.#2650
Merged
fujitatomoya merged 2 commits intorollingfrom Oct 19, 2024
Merged
set QoS History KEEP_ALL explicitly for statistics publisher.#2650fujitatomoya merged 2 commits intorollingfrom
fujitatomoya merged 2 commits intorollingfrom
Conversation
clalancette
reviewed
Oct 15, 2024
rclcpp/test/rclcpp/topic_statistics/test_subscription_topic_statistics.cpp
Outdated
Show resolved
Hide resolved
fujitatomoya
commented
Oct 15, 2024
rclcpp/test/rclcpp/topic_statistics/test_subscription_topic_statistics.cpp
Outdated
Show resolved
Hide resolved
rclcpp/include/rclcpp/topic_statistics/subscription_topic_statistics.hpp
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@clalancette can you take a look at this? |
bd0fc82 to
3390c9d
Compare
fujitatomoya
commented
Oct 15, 2024
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
3390c9d to
c22e883
Compare
Collaborator
Author
|
Pulls: #2650
|
clalancette
approved these changes
Oct 16, 2024
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me with green CI.
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Collaborator
Author
|
CI:
|
Crola1702
pushed a commit
that referenced
this pull request
Oct 28, 2024
* set QoS History KEEP_ALL explicitly for statistics publisher. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * test_subscription_options adjustment. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
clalancette
pushed a commit
that referenced
this pull request
Oct 30, 2024
…#2657) * set QoS History KEEP_ALL explicitly for statistics publisher. * test_subscription_options adjustment. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2588