[Backport] set QoS History KEEP_ALL explicitly for statistics publisher. (#2650)#2657
Merged
clalancette merged 1 commit intojazzyfrom Oct 30, 2024
Merged
Conversation
* set QoS History KEEP_ALL explicitly for statistics publisher. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * test_subscription_options adjustment. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Contributor
Author
|
CI:
|
This was referenced Oct 28, 2024
fujitatomoya
approved these changes
Oct 30, 2024
Collaborator
|
i really do not think https://ci.ros2.org/job/ci_windows/22770/ is related to this fix. |
Collaborator
|
@Crola1702 can you merge this? |
clalancette
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #2650
closes #2588