Skip to content

Make create_service accept rclcpp::QoS#1969

Merged
fujitatomoya merged 1 commit intorollingfrom
sloretz__create_service_qos
Jul 12, 2022
Merged

Make create_service accept rclcpp::QoS#1969
fujitatomoya merged 1 commit intorollingfrom
sloretz__create_service_qos

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Jul 11, 2022

Follow up to #1964, this allows using rclcpp::QoS with create_service and deprecates the version taking rmw_qos_profile_t

@sloretz
Make create_service accept rclcpp::QoS
20b8238 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz added the enhancement New feature or request label Jul 11, 2022
@sloretz sloretz self-assigned this Jul 11, 2022
@sloretz sloretz mentioned this pull request Jul 11, 2022
Merged
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Jul 11, 2022

CI (build: --packages-above-and-dependencies rclcpp rclcpp_lifecycle test: --packages-select rclcpp rclcpp_lifecycle test_rclcpp test_quality_of_service)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya approved these changes Jul 12, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Jul 12, 2022

@sloretz i will go ahead to merge this since we have green on CI.

@fujitatomoya fujitatomoya merged commit 64e4c72 into rolling Jul 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the sloretz__create_service_qos branch July 12, 2022 00:41
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Jul 12, 2022

@fujitatomoya I'll assume your approval is good for ros2/system_tests#507 and merge that one too.

@sloretz sloretz mentioned this pull request Mar 26, 2025
Closed
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Mar 26, 2025

@Mergifyio backport humble

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 26, 2025 •
edited
Loading

backport humble

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Mar 26, 2025
@sloretz @mergify
Make create_service accept rclcpp::QoS (#1969)
2c1957f 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
(cherry picked from commit 64e4c72)

# Conflicts:
#	rclcpp_lifecycle/CMakeLists.txt
@mergify mergify bot mentioned this pull request Mar 26, 2025
Closed
sloretz added a commit that referenced this pull request Mar 26, 2025
@sloretz
Backport: Make create_service accept rclcpp::QoS (#1969)
f9508f8 
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
@sloretz sloretz mentioned this pull request Mar 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@sloretz sloretz

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sloretz @fujitatomoya