Skip to content

Make create_service accept rclcpp::QoS (backport #1969)#2778

Closed
mergify[bot] wants to merge 1 commit intohumblefrom
mergify/bp/humble/pr-1969
Closed

Make create_service accept rclcpp::QoS (backport #1969)#2778
mergify[bot] wants to merge 1 commit intohumblefrom
mergify/bp/humble/pr-1969

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Mar 26, 2025

Follow up to #1964, this allows using rclcpp::QoS with create_service and deprecates the version taking rmw_qos_profile_t


This is an automatic backport of pull request #1969 done by Mergify.

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
(cherry picked from commit 64e4c72)

# Conflicts:
#	rclcpp_lifecycle/CMakeLists.txt
@mergify mergify bot added the conflicts label Mar 26, 2025
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Mar 26, 2025

Cherry-pick of 64e4c72 has failed:

On branch mergify/bp/humble/pr-1969
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 64e4c72.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   rclcpp/include/rclcpp/create_service.hpp
	modified:   rclcpp/include/rclcpp/node.hpp
	modified:   rclcpp/include/rclcpp/node_impl.hpp
	modified:   rclcpp/test/rclcpp/strategies/test_allocator_memory_strategy.cpp
	modified:   rclcpp/test/rclcpp/test_client.cpp
	modified:   rclcpp/test/rclcpp/test_memory_strategy.cpp
	modified:   rclcpp/test/rclcpp/test_service.cpp
	modified:   rclcpp_lifecycle/include/rclcpp_lifecycle/lifecycle_node.hpp
	modified:   rclcpp_lifecycle/include/rclcpp_lifecycle/lifecycle_node_impl.hpp
	new file:   rclcpp_lifecycle/test/test_service.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rclcpp_lifecycle/CMakeLists.txt

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@sloretz
Copy link
Copy Markdown
Contributor

sloretz commented Mar 26, 2025

I'll try doing this backport manually - I need to edit out the deprecation of the old API anyways for Humble

edit: #2779

@sloretz sloretz closed this Mar 26, 2025
@sloretz sloretz deleted the mergify/bp/humble/pr-1969 branch March 26, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant