Make create_service accept rclcpp::QoS (backport #1969)#2778
Closed
mergify[bot] wants to merge 1 commit intohumblefrom
Closed
Make create_service accept rclcpp::QoS (backport #1969)#2778mergify[bot] wants to merge 1 commit intohumblefrom
mergify[bot] wants to merge 1 commit intohumblefrom
Conversation
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> (cherry picked from commit 64e4c72) # Conflicts: # rclcpp_lifecycle/CMakeLists.txt
Contributor
Author
|
Cherry-pick of 64e4c72 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Contributor
|
I'll try doing this backport manually - I need to edit out the deprecation of the old API anyways for Humble edit: #2779 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #1964, this allows using
rclcpp::QoSwithcreate_serviceand deprecates the version takingrmw_qos_profile_tThis is an automatic backport of pull request #1969 done by Mergify.