Backport: Make create_service accept rclcpp::QoS (#1969)#2779
Closed
Backport: Make create_service accept rclcpp::QoS (#1969)#2779
Conversation
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
This was referenced Mar 26, 2025
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
fujitatomoya
approved these changes
Apr 7, 2025
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI
Collaborator
|
Pulls: #2779
|
jmachowinski
approved these changes
Apr 7, 2025
Collaborator
|
Hm, this might break existing code... The CI is sadly proof of this. Therefore I would drop the backport. |
Contributor
Author
Darn :( I don't know how to resolve this. Thank you for the review. I'll close this backport. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports #1969 with one exception: it does NOT backport the deprecation of the old API. This enables existing ROS Humble users to use the new API.