Changes based on comments on PR #72#74
Merged
wjwwood merged 8 commits intoros2:parameters_support_rangesfrom Apr 25, 2019
Merged
Conversation
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
b0892b0 to
ce23afa
Compare
wjwwood
reviewed
Apr 23, 2019
added 2 commits
April 23, 2019 18:48
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
wjwwood
reviewed
Apr 24, 2019
added 2 commits
April 24, 2019 16:07
…er line on ParameterDescriptor Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
…valid even if it is not multiple of step Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
wjwwood
reviewed
Apr 25, 2019
wjwwood
reviewed
Apr 25, 2019
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
Author
|
I think I addressed all the comments based on what was discussed here and offline. |
wjwwood
reviewed
Apr 25, 2019
Member
I think there are still several that have not been addressed. |
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
wjwwood
reviewed
Apr 25, 2019
wjwwood
approved these changes
Apr 25, 2019
Member
wjwwood
left a comment
There was a problem hiding this comment.
After the minor style change is addressed, lgtm!
Thanks for pushing on it, @gonzodepedro.
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
wjwwood
pushed a commit
that referenced
this pull request
Apr 25, 2019
* Added changes based on comments on PR #72 Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Minor changes based on comments Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Augmented comments on ParameterDescriptor constraints Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Changed comment on 'step' field of FloatingPointRange. One sentence per line on ParameterDescriptor Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Changed comments on IntegerRange and FloatingPointRange, to_value is valid even if it is not multiple of step Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Addressed multiple comments Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Improved documentation Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Oxford comma FTW! Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> Signed-off-by: William Woodall <william@osrfoundation.org>
wjwwood
pushed a commit
that referenced
this pull request
Apr 25, 2019
* Added changes based on comments on PR #72 Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Minor changes based on comments Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Augmented comments on ParameterDescriptor constraints Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Changed comment on 'step' field of FloatingPointRange. One sentence per line on ParameterDescriptor Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Changed comments on IntegerRange and FloatingPointRange, to_value is valid even if it is not multiple of step Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Addressed multiple comments Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Improved documentation Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Oxford comma FTW! Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> Signed-off-by: William Woodall <william@osrfoundation.org>
wjwwood
added a commit
that referenced
this pull request
Apr 29, 2019
* small cleanup commit Signed-off-by: William Woodall <william@osrfoundation.org> * first proposal from Dirk Signed-off-by: William Woodall <william@osrfoundation.org> * add description fields in the parameter descriptor (#73) Signed-off-by: William Woodall <william@osrfoundation.org> * Changes based on comments on PR #72 (#74) * Added changes based on comments on PR #72 Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Minor changes based on comments Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Augmented comments on ParameterDescriptor constraints Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Changed comment on 'step' field of FloatingPointRange. One sentence per line on ParameterDescriptor Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Changed comments on IntegerRange and FloatingPointRange, to_value is valid even if it is not multiple of step Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Addressed multiple comments Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Improved documentation Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Oxford comma FTW! Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> Signed-off-by: William Woodall <william@osrfoundation.org> * remove draft comment Signed-off-by: William Woodall <william@osrfoundation.org> * Added new messages file to cmakelists Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Changed double to float64 to be consistent with parameter values Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Alphabetized msg file list on CMakeList Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.