Move builtin_interfaces to rcl_interfaces repository#26
Merged
mikaelarguedas merged 15 commits intomasterfrom Nov 29, 2017
Merged
Move builtin_interfaces to rcl_interfaces repository#26mikaelarguedas merged 15 commits intomasterfrom
mikaelarguedas merged 15 commits intomasterfrom
Conversation
96e8f29 to
8ef56ab
Compare
Closed
8ef56ab to
c01ef35
Compare
Member
Author
|
hmmm so I migrated all the history along hence the number of commits in this PR. Github PR UI doesnt like the unrelated histories though so the individual commits cannot be displayed in this PR but if you try to blame any of the migrated files you can see the history was preserved |
tfoote
approved these changes
Nov 29, 2017
Member
Author
|
CI to convince myself nothing went wrong during the migration:
The build step finished successfully so I'll go ahead and merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is needed to be able to use
builtin_interfacesinrcl_interfacesmessages without having to release the common_interfaces repository before this one.Note: this release order was already compromised when introducing
test_msgsthat is usingbuiltin_interfaces