adding test_msgs to rcl_interfaces repo#16
Conversation
|
Once the message definitions and fixtures have been move https://github.com/ros2/ros2cli/blob/9fce6a08381bb67cf17e7160b0b2c6556ffec1e6/ros2topic/package.xml#L16 should switch to the new location. |
cedd35a to
822664a
Compare
|
I think it would be valuable to preserve the history of the moved content. These files have quite some history which would be valuable for future debugging / tracing. |
d7e9ccd to
4dbffec
Compare
|
history of the files has been propagated, ready for review |
Conflicts: test_communication/test/message_fixtures.hpp
Conflicts: test_communication/test/message_fixtures.hpp
* use ASCII value for char * homogenize BoundedArrayPrimitives fixtures
* extend service template to test python services * trailing whitespace * skipping tests raising SkipTest * remove SKIP_TEST for non nose tests * add bracket because linter doesnt understand multiline conditions
* Added nested message that always breaks because of the bug * Added C++ code for DynamicArrayPrimitivesNested message * Fixed style and publisher/subscriber (combo) test case * expose core dumpes on complex messages * dont run other tests to save debugging time * more fixtures, looks like a string array alignment issue * newline at end of file * move include to the right place * add comment about current failing tests * remove debug prints * restore/reenable all tests * that was actually pretty readable with vertical space * use all messages fron the fixtures rather the only the first one * linters * what's cool with functions is that you can call them rather than copy-n-paste code
add __init__.py
remove unused message type update header guard rename message field in DynamicArrayPrimitivesNested
4dbffec to
3f5b5ed
Compare
| <name>test_msgs</name> | ||
| <version>0.0.0</version> | ||
| <description>A package containing message definitions and fixtures used exclusively for testing purposes.</description> | ||
| <maintainer email="karsten@osrfoundation.org">Karsten Knese</maintainer> |
There was a problem hiding this comment.
Not sure why you picked @Karsten1987 but I don't mind 😉
There was a problem hiding this comment.
he is the one that started the original work in ros2/common_interfaces#30 and I took over, I figured he'd like to keep maintainership 😜
There was a problem hiding this comment.
I figured he'd like to keep maintainership
Very generous of you 😆 Works for me...
| ) | ||
|
|
||
| install(DIRECTORY src/test_msgs | ||
| DESTINATION "${PYTHON_INSTALL_DIR}/") |
There was a problem hiding this comment.
This Python package doesn't have an __init__.py file. Should it?
There was a problem hiding this comment.
Nvm, just found the file being added in a later commit.
replaces ros2/common_interfaces#30
Fix ros2/system_tests#191
Connects to ros2/system_tests#191