Skip to content

[backport dashing] Don't check history depth if RMW_QOS_POLICY_HISTORY_KEEP_ALL#595

Merged
ivanpauno merged 1 commit intoros2:dashingfrom
RoverRobotics-forks:pr-3
Mar 11, 2020
Merged

[backport dashing] Don't check history depth if RMW_QOS_POLICY_HISTORY_KEEP_ALL#595
ivanpauno merged 1 commit intoros2:dashingfrom
RoverRobotics-forks:pr-3

Conversation

@rotu
Copy link
Copy Markdown
Contributor

@rotu rotu commented Mar 10, 2020

@rotu
Copy link
Copy Markdown
Contributor Author

rotu commented Mar 11, 2020

@jacobperron, could you please review?

@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Mar 11, 2020

Please first get the original PR reviewed and merged before opening backport PRs. Also mark them in the title a bit clearer (I just updated it) and also when doing backports do target all active distros is applicable - in this case Eloquent.

@dirk-thomas dirk-thomas changed the title [D] Don't check history depth if RMW_QOS_POLICY_HISTORY_KEEP_ALL [backport dashing] Don't check history depth if RMW_QOS_POLICY_HISTORY_KEEP_ALL Mar 11, 2020
rotu added a commit to rotu/ros2_documentation that referenced this pull request Mar 11, 2020
@rotu
Backport guidelines
8adc8f8 
As per ros2/rcl#595 (comment)
@rotu rotu mentioned this pull request Mar 11, 2020
Merged
dirk-thomas pushed a commit to ros2/ros2_documentation that referenced this pull request Mar 11, 2020
@rotu
Backport guidelines (#560)
bc357bf 
* Backport guidelines

As per ros2/rcl#595 (comment)

* Address review feedback
@ivanpauno
Copy link
Copy Markdown
Member

ivanpauno commented Mar 11, 2020

Though backporting a test is not super useful, it will clean up the current build failures: http://build.ros2.org/view/Dci/job/Dci__nightly-cyclonedds_ubuntu_bionic_amd64/207/testReport/junit/rcl/TestWithDifferentQoSSettings_TestGetActualQoS__rmw_cyclonedds_cpp/test_publisher_get_qos_settings_publisher_non_default_qos__publisher_non_default_qos______________________/
So, I will go ahead with it.

The original PR was already merged and the checker is passing, merging this one too.

@ivanpauno ivanpauno merged commit fdf6539 into ros2:dashing Mar 11, 2020
rotu added a commit to RoverRobotics-forks/rcl that referenced this pull request Mar 11, 2020
@rotu
[Eloquent] Don't check history depth if RMW_QOS_POLICY_HISTORY_KEEP_A…
2b34859 
…LL (ros2#595)

Backport of ros2#593

Signed-off-by: Dan Rose <dan@digilabs.io>
rotu added a commit to RoverRobotics-forks/rcl that referenced this pull request Mar 11, 2020
@rotu
[Eloquent] Don't check history depth if RMW_QOS_POLICY_HISTORY_KEEP_A…
5322489 
…LL (ros2#595)

Backport of ros2#593

Signed-off-by: Dan Rose <dan@digilabs.io>
ivanpauno pushed a commit that referenced this pull request Mar 12, 2020
@rotu
[Eloquent] Don't check history depth if RMW_QOS_POLICY_HISTORY_KEEP_A…
bdc485c 
…LL (#595) (#596)

Backport of #593

Signed-off-by: Dan Rose <dan@digilabs.io>
ferranm99 added a commit to ferranm99/ferran-ros that referenced this pull request May 20, 2022
@ferranm99
Backport guidelines (#560)
d4914a5 
* Backport guidelines

As per ros2/rcl#595 (comment)

* Address review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rotu @dirk-thomas @ivanpauno