Skip to content

[Eloquent] Don't check history depth if RMW_QOS_POLICY_HISTORY_KEEP_ALL (#595)#596

Merged
ivanpauno merged 1 commit intoros2:eloquentfrom
RoverRobotics-forks:pr-3
Mar 12, 2020
Merged

[Eloquent] Don't check history depth if RMW_QOS_POLICY_HISTORY_KEEP_ALL (#595)#596
ivanpauno merged 1 commit intoros2:eloquentfrom
RoverRobotics-forks:pr-3

Conversation

@rotu
Copy link
Copy Markdown
Contributor

@rotu rotu commented Mar 11, 2020

Backport of #593

Signed-off-by: Dan Rose dan@digilabs.io

ivanpauno
ivanpauno requested changes Mar 11, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this

rcl/rcl/test/rcl/test_get_actual_qos.cpp

Lines 225 to 227 in 2b34859

EXPECT_EQ(
qos->depth,
parameters.qos_expected.depth);
?

@rotu
[Eloquent] Don't check history depth if RMW_QOS_POLICY_HISTORY_KEEP_A…
5322489 
…LL (ros2#595)

Backport of ros2#593

Signed-off-by: Dan Rose <dan@digilabs.io>
@rotu
Copy link
Copy Markdown
Contributor Author

rotu commented Mar 11, 2020

What about this

rcl/rcl/test/rcl/test_get_actual_qos.cpp

Lines 225 to 227 in 2b34859

EXPECT_EQ(
qos->depth,
parameters.qos_expected.depth);

?

Oh shoot! good catch!

@rotu rotu requested a review from ivanpauno March 11, 2020 21:21
@ivanpauno ivanpauno merged commit bdc485c into ros2:eloquent Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rotu @ivanpauno @mjcarroll