Accept quoted int or float values as strings#464
Merged
Conversation
42a7114 to
43e4cc5
Compare
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
43e4cc5 to
ead0691
Compare
Member
Author
|
CI, just to keep the things going (up to rcl, only fastrtps):
|
jacobperron
reviewed
Jun 26, 2019
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Member
Author
|
Thank you @jacobperron for the review. I realized that I built/ran tests up to CI (up to rcl_yaml_param_parser, only fastrtps):
|
jacobperron
approved these changes
Jun 26, 2019
Member
jacobperron
left a comment
There was a problem hiding this comment.
Looks good. Two more small things.
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Member
Author
|
CI (up to rcl_yaml_param_parser, only fastrtps):
|
jacobperron
approved these changes
Jun 27, 2019
ivanpauno
added a commit
that referenced
this pull request
Jul 24, 2019
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
ivanpauno
added a commit
that referenced
this pull request
Jul 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #461.
Replaces #251.
This is #251 rebased with master, and with the bug fix over it.
Similar to #415.