Skip to content

Add failing test quoted number in string array#251

Closed
sloretz wants to merge 1 commit intomasterfrom
yaml_quoted_string_array
Closed

Add failing test quoted number in string array#251
sloretz wants to merge 1 commit intomasterfrom
yaml_quoted_string_array

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Jun 5, 2018

This adds a failing test and isn't intended to be merged.

Is there is another way to specify string array values in yaml? If a string array contains a quoted number then the parser complains about a type change.

1: [ RUN      ] test_file_parser.string_array_with_quoted_number
1: cur_path: /workspace/ros2-dev0/src/ros2/rcl/rcl_yaml_param_parser/test/string_array_with_quoted_number.yaml
1: Sequence should be of same type. Value type 'integer' do not belong at line_num 4, at /workspace/ros2-dev0/src/ros2/rcl/
rcl_yaml_param_parser/src/parser.c:914
1: /workspace/ros2-dev0/src/ros2/rcl/rcl_yaml_param_parser/test/test_parse_yaml.cpp:55: Failure
1: Value of: res
1:   Actual: false
1: Expected: true

@sloretz sloretz added bug Something isn't working ready Work is about to start (Kanban column) in progress Actively being worked on (Kanban column) and removed ready Work is about to start (Kanban column) labels Jun 5, 2018
@sloretz sloretz requested review from anup-pem and removed request for anup-pem June 5, 2018 00:36
@jacobperron jacobperron mentioned this pull request Jun 20, 2019
Closed
@ivanpauno ivanpauno mentioned this pull request Jun 21, 2019
Merged
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Jul 11, 2019

Closing since it was replaced by #464 which has been merged 🎉

@sloretz sloretz closed this Jul 11, 2019
@sloretz sloretz deleted the yaml_quoted_string_array branch July 11, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sloretz sloretz

Labels

bug Something isn't working in progress Actively being worked on (Kanban column)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sloretz