Conversation
1. *always* pass a file object to parser implementation. Passing a string introduces no extra expressiveness and the file is not guaranteed to be properly closed. 2. Use more Pythonic type detection for whether passed object is a string or a file. 3. Clean up type declarations 4. Clean up parser ordering logic 5. Make parser ordering deterministic 6. Remove use of Ellipsis. It makes the declaration look like a stub. Signed-off-by: Dan Rose <dan@digilabs.io>
|
If this should be split into multiple PRs, please suggest how to split it up. |
Signed-off-by: Dan Rose <dan@digilabs.io>
Signed-off-by: Dan Rose <dan@digilabs.io>
Signed-off-by: Dan Rose <dan@digilabs.io>
hidmic
left a comment
There was a problem hiding this comment.
I presume this includes #415. Nevermind the comments over there, this makes sense to me. @ivanpauno ?
Same pattern, different packages. You're right, my bad. On a second look, my comment over there was addressed here. |
Signed-off-by: Dan Rose <dan@digilabs.io>
Signed-off-by: Dan Rose <dan@digilabs.io>
|
@dirk-thomas @ivanpauno where is this PR at? Is it ready for CI? Is there feedback that still needs to be addressed? |
|
I need to fix the copyrights to say “Open Avatar Inc.” instead of “Rover Robotics ℅ Dan Rose” since Rover Robotics is a dba. I’ll move it out of draft again when I get around to that |
Rover Robotics is the trade name (DBA), not the copyright owner. Signed-off-by: Dan Rose <dan@digilabs.io>
|
@jacobperron ok to merge this before Foxy relase? should be merge after the release? |
|
@ivanpauno Unless you think it's crucial, I'd rather hold until after the rosdistro freeze (May 27th). |
|
0e2126f to
f876b96
Compare
Signed-off-by: Dan Rose <dan@digilabs.io>
aa5a57f to
5c150d2
Compare
|
Blech. I struggle with Git sometimes, but I think this is now ready for merge. |
|
|
Failing tests are unrelated, merging! |
Signed-off-by: Dan Rose <dan@digilabs.io>
Signed-off-by: Dan Rose <dan@digilabs.io>
Signed-off-by: Dan Rose dan@digilabs.io