Skip to content

Close YAML file when we're done.#415

Merged
ivanpauno merged 6 commits intoros2:masterfrom
rotu:close_yaml_file
Jul 1, 2020
Merged

Close YAML file when we're done.#415
ivanpauno merged 6 commits intoros2:masterfrom
rotu:close_yaml_file

Conversation

@rotu
Copy link
Copy Markdown
Contributor

@rotu rotu commented May 6, 2020

Signed-off-by: Dan Rose dan@digilabs.io

Signed-off-by: Dan Rose <dan@digilabs.io>
@hidmic
Copy link
Copy Markdown

hidmic commented May 14, 2020

@rotu ping.

@ivanpauno ivanpauno mentioned this pull request May 14, 2020
@rotu rotu marked this pull request as draft May 14, 2020 15:19
@rotu
Copy link
Copy Markdown
Contributor Author

rotu commented May 14, 2020

converting to draft to wait until #414 is done

@rotu rotu force-pushed the close_yaml_file branch from 099d9c9 to af011b6 Compare May 28, 2020 22:28
@rotu rotu force-pushed the close_yaml_file branch 2 times, most recently from 9c39fae to 8e0e317 Compare June 15, 2020 19:42
@ivanpauno
Copy link
Copy Markdown
Member

@rotu friendly ping

@rotu rotu force-pushed the close_yaml_file branch from 7cccf99 to 794ee65 Compare June 30, 2020 23:58
rotu added 3 commits June 30, 2020 19:03
Signed-off-by: Dan Rose <dan@digilabs.io>
Signed-off-by: Dan Rose <dan@digilabs.io>
Signed-off-by: Dan Rose <dan@digilabs.io>
@rotu rotu force-pushed the close_yaml_file branch from 794ee65 to 9b18a21 Compare July 1, 2020 00:04
@rotu rotu marked this pull request as ready for review July 1, 2020 00:04
@rotu
Copy link
Copy Markdown
Contributor Author

rotu commented Jul 1, 2020

Thanks, @ivanpauno

Signed-off-by: Dan Rose <dan@digilabs.io>
Copy link
Copy Markdown
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Dan Rose <dan@digilabs.io>
@ivanpauno
Copy link
Copy Markdown
Member

Rci job is passing, merging!
Thanks for the fix @rotu!

@ivanpauno ivanpauno merged commit 85a7435 into ros2:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants