Skip to content

Add support for anon substitution#384

Merged
Blast545 merged 5 commits intomasterfrom
blast545/anon_substitution
Mar 4, 2020
Merged

Add support for anon substitution#384
Blast545 merged 5 commits intomasterfrom
blast545/anon_substitution

Conversation

@Blast545
Copy link
Copy Markdown
Contributor

This commit adds the anonymous name substitution, similar to the one provided in ROS1.

Includes as well testing for the perform function of the substitution. This PR will close #289.

Signed-off-by: Jorge J. Perez jjperez@ekumenlabs.com

This commit adds the anonymous name substitution,
similar to the one provided in ROS1.
Includes as well testing for the perform function
of the substitution.

Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 self-assigned this Feb 18, 2020
@Blast545 Blast545 added the enhancement New feature or request label Feb 18, 2020
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 requested a review from hidmic February 18, 2020 19:16
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 requested a review from hidmic February 19, 2020 16:41
Copy link
Copy Markdown

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI

Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Copy link
Copy Markdown
Contributor Author

Blast545 commented Mar 2, 2020

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Minor changes after review, and green CI, will merge

@Blast545 Blast545 merged commit f90f4d7 into master Mar 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the blast545/anon_substitution branch March 4, 2020 15:10
tetov added a commit to tetov/ros2_documentation that referenced this pull request Mar 18, 2025
Support for anon substitution was added in
ros2/launch#384 and is available from ROS2 foxy.
ahcorde pushed a commit to ros2/ros2_documentation that referenced this pull request Mar 18, 2025
Support for anon substitution was added in
ros2/launch#384 and is available from ROS2 foxy.
mergify bot pushed a commit to ros2/ros2_documentation that referenced this pull request Mar 18, 2025
Support for anon substitution was added in
ros2/launch#384 and is available from ROS2 foxy.

(cherry picked from commit 1dcc9cc)
mergify bot pushed a commit to ros2/ros2_documentation that referenced this pull request Mar 18, 2025
Support for anon substitution was added in
ros2/launch#384 and is available from ROS2 foxy.

(cherry picked from commit 1dcc9cc)
ahcorde pushed a commit to ros2/ros2_documentation that referenced this pull request Mar 18, 2025
)

Support for anon substitution was added in
ros2/launch#384 and is available from ROS2 foxy.

(cherry picked from commit 1dcc9cc)

Co-authored-by: Anton Tetov <anton@tetov.se>
ahcorde pushed a commit to ros2/ros2_documentation that referenced this pull request Mar 18, 2025
)

Support for anon substitution was added in
ros2/launch#384 and is available from ROS2 foxy.

(cherry picked from commit 1dcc9cc)

Co-authored-by: Anton Tetov <anton@tetov.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Anon substitution

2 participants