Skip to content

[introspector] bugfix representation when env is set#222

Merged
wjwwood merged 2 commits intocrystalfrom
stonier-patch-1
Apr 1, 2019
Merged

[introspector] bugfix representation when env is set#222
wjwwood merged 2 commits intocrystalfrom
stonier-patch-1

Conversation

@wjwwood
Copy link
Copy Markdown
Member

@wjwwood wjwwood commented Mar 30, 2019

Replacement for #220.

@wjwwood wjwwood added the in review Waiting for review (Kanban column) label Mar 30, 2019
@wjwwood wjwwood self-assigned this Mar 30, 2019
@wjwwood wjwwood mentioned this pull request Mar 30, 2019
Closed
@wjwwood
Copy link
Copy Markdown
Member Author

wjwwood commented Mar 30, 2019

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@nuclearsandwich nuclearsandwich mentioned this pull request Mar 30, 2019
Closed
8 tasks
@stonier @wjwwood
[introspector] bugfix representation when env is set
1b606dd 
Resolves #203.

Signed-off-by: Daniel Stonier <d.stonier@gmail.com>
@wjwwood
Copy link
Copy Markdown
Member Author

wjwwood commented Mar 30, 2019

New CI after actually backporting #169 to crystal and rebasing this pr:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood wjwwood changed the base branch from master to crystal March 30, 2019 00:31
@wjwwood wjwwood closed this Mar 30, 2019
@wjwwood wjwwood reopened this Mar 30, 2019
@wjwwood wjwwood added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels Mar 30, 2019
@wjwwood
Copy link
Copy Markdown
Member Author

wjwwood commented Mar 30, 2019

DCO is confused, it is looking for Shane's sign-off, but I stonier authored it, and GitHub committed it on my behalf...

It was signed-off by stonier and authored by him, so I'm going to count that as a false positive.

@wjwwood wjwwood added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Mar 30, 2019
@wjwwood
Copy link
Copy Markdown
Member Author

wjwwood commented Mar 30, 2019

Looks like DCO is actually complaining about a commit that's not in the pr... I'm going to amend the commit and force push to see if I can get it to re-calculate.

@wjwwood
debugging DCO issues
5d64cd6 
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood
Copy link
Copy Markdown
Member Author

wjwwood commented Mar 30, 2019

Looks like the empty commit 5d64cd6 brought it to its senses.

hidmic
hidmic approved these changes Apr 1, 2019
View reviewed changes
Copy link
Copy Markdown

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wjwwood wjwwood merged commit 36f47cf into crystal Apr 1, 2019
@wjwwood wjwwood deleted the stonier-patch-1 branch April 1, 2019 20:03
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hidmic hidmic hidmic approved these changes

Assignees

@wjwwood wjwwood

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wjwwood @hidmic @stonier