Skip to content

[introspector] failing when env is set by the user #203

@stonier

Description

@stonier

Bug report

Required Info:

  • Operating System:
    • Ubuntu 18.04
  • Installation type:
    • binaries
  • Version or commit hash:
    • crystal
  • DDS implementation:
    • default
  • Client library (if applicable):
    • n/a

Steps to reproduce issue

Add an env dict to the arguments for a node action and also call the introspector.

    launch_description = launch.LaunchDescription()
    launch_description.add_action(
        launch_ros.actions.Node(
            package='py_trees_ros_tutorials',
            node_name="one",
            node_executable="tree-data-gathering",
            output='screen',
            env={'PYTHONUNBUFFERED': '1'}
        )
    )
    print(launch.LaunchIntrospector().format_launch_description(launch_description))

Expected behavior

No errors.

Actual behavior

Traceback (most recent call last):
  File "/mnt/mervin/workspaces/crystal/py_trees/install/py_trees_ros_tutorials/lib/py_trees_ros_tutorials/tutorial-one-data-gathering", line 11, in <module>
    load_entry_point('py-trees-ros-tutorials', 'console_scripts', 'tutorial-one-data-gathering')()
  File "/mnt/mervin/workspaces/crystal/py_trees/build/py_trees_ros_tutorials/py_trees_ros_tutorials/one_data_gathering.py", line 123, in launch_main
    print(launch.LaunchIntrospector().format_launch_description(launch_description))
  File "/opt/ros/crystal/lib/python3.6/site-packages/launch/launch_introspector.py", line 134, in format_launch_description
    entity_descriptions = format_entities(launch_description.entities)
  File "/opt/ros/crystal/lib/python3.6/site-packages/launch/launch_introspector.py", line 74, in format_entities
    result.extend(format_action(cast(Action, entity)))
  File "/opt/ros/crystal/lib/python3.6/site-packages/launch/launch_introspector.py", line 114, in format_action
    for k, v in typed_action.env.items()]) + '}',
AttributeError: 'list' object has no attribute 'items'

Metadata

Metadata

Assignees

Labels

bugSomething isn't workinggood first issueGood for newcomershelp wantedExtra attention is needed

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions