[introspector] bugfix representation when env is set#220
Closed
stonier wants to merge 1 commit intoros2:crystalfrom
Closed
[introspector] bugfix representation when env is set#220stonier wants to merge 1 commit intoros2:crystalfrom
stonier wants to merge 1 commit intoros2:crystalfrom
Conversation
Resolves ros2#203. Signed-off-by: Daniel Stonier <d.stonier@gmail.com>
Member
|
Sorry we don't take pr's to released branches, please comment on the pull request that introduced the fix into master and we'll consider cherry-picking it for the next Crystal patch release. |
This was referenced Mar 27, 2019
Member
|
Closing (again) in favor of #222 because it's easier for me to test against crystal properly when it's a branch on our repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #203.
Note, not needed on master, since this has been fixed in 632ef1f#diff-970fc3c5d394ad33c14e4f9fe55288ceR113.