MessageFilter Generalizated Nodes#661
Closed
CursedRock17 wants to merge 4 commits intoros2:rollingfrom
Closed
Conversation
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
Contributor
|
@clalancette what do you think about this?
I can see both strategies in some other packages, any recomendation ? |
…_kdl (ros2#657)"" This reverts commit 0ed5d79cecd0e3bb10ef08a6471241b9d47ae315.
Contributor
|
@CursedRock17 friendly ping to rebase the PR 🧇 |
Contributor
Author
Contributor
Agreed with your reasoning. In that case, I'm going to close this out. But feel free to reopen if you think we should pursue this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should entirely resolve #95 as pull request #96 didn't use a templated
Nodein theMessageFilterconstructors. There were concerns of:which we can do with defaulted templated
Nodesandnode_interfacemethods.