On Windows fix installation directory of .dll files in tf2_eigen_kdl#657
On Windows fix installation directory of .dll files in tf2_eigen_kdl#657clalancette merged 1 commit intoros2:rollingfrom
Conversation
Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
|
The CI error (from https://build.ros2.org/job/Rpr__geometry2__ubuntu_noble_amd64/2/console) is: that seems unrelated to the PR content. |
|
As a kind of OT comment, as soon as we can require CMake 3.14, all the |
For Rolling, at least, we now require CMake 3.20 due to some (unrelated) changes. So we can do this if you want. That said, it is a different effort, so I'm still going to merge this one as-is. |
Sure, I just realized this while writing this PR, so I wanted to write it down somehow. Just bumping the |
…_kdl (ros2#657)"" This reverts commit 0ed5d79cecd0e3bb10ef08a6471241b9d47ae315.
For consistency with the rest of geometry2 :
geometry2/tf2/CMakeLists.txt
Line 40 in b81000d
geometry2/tf2_ros/CMakeLists.txt
Line 104 in b81000d
On Windows it is important to install the
.dlllibraries (RUNTIMEin CMake jargon) in<prefix>/bin, as otherwise the Windows dynamic loader is not able to find them.Cross-ref downstream issue: