Merged
Conversation
Removing until this feature is supported by the bridge. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
dirk-thomas
approved these changes
Feb 7, 2019
Member
Author
|
Expecting the |
Member
I'm assuming this addresses a specific issue which justifies it's backport? Can you please add it to ros2/ros2#647 |
Member
Author
I should have populated the description. It fixes a compiler warning in ROS 1 bridge, since the bridge does not yet support Actions. I'll add it to the description of ros2/ros2#647 and a comment once this is merged. |
Member
I added it to the changes in progress section so I don't forget about it. Feel free to move it once it merges. |
sloretz
referenced
this pull request
Feb 8, 2019
* Add Fibonacci action Also added mapping rules for the Fibonacci action from ROS 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing until this feature is supported by the bridge.
@nuclearsandwich I think this should go in Crystal Patch 2.