Add launch XML substitution for a packages share directory#254
Add launch XML substitution for a packages share directory#254jacobperron merged 2 commits intoroslaunchfrom
Conversation
Rename find-pkg to find-pkg-prefix. Add find-pkg-share substitution for the share directory. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
Alternatively, we could re-use the name Thoughts? |
Common or not my argument is that it is opaque to the user what it maps to. The user must read docs to understand its behavior which I think is not good naming. |
|
I think they'll have to read the documentation (or infer its behavior from an example) anyways. I always prefer more explicit names, so I'm ok with |
|
I prefer the explicit names |
|
Thanks for the feedback everyone! I'll proceed with explicit names ( |
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* wip * more work in progress * more work done on the calling conventions section * added context section, still a WIP * updated event sections * event filters * fixup even handler subsection * typos * add subsections about the system description (language agnostic) * Proposal for launching dynamically composable nodes (#206) * Proposal for dynamically composed nodes * allow multiple extra_arguments * Allow node_name and namespace to be empty * Human readable error message * Update articles/150_roslaunch.md Co-Authored-By: sloretz <shane.loretz@gmail.com> * Assign nodes unique ids, but still forbid duplicates * Update articles/150_roslaunch.md Co-Authored-By: sloretz <shane.loretz@gmail.com> * Update articles/150_roslaunch.md Co-Authored-By: sloretz <shane.loretz@gmail.com> * Section to list * More generic wording about container processes * namespace -> node_namespace * _launch/ -> ~/_container/ Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Propose ROS 2 launch front-end design hints. (#208) Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * Adds ROS 2 launch XML format design document (#207) Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * Update ROS launch documentation (frontend documents) (#247) Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * review fixup Signed-off-by: William Woodall <william@osrfoundation.org> * clarify lifecycle transition due to review comment Signed-off-by: William Woodall <william@osrfoundation.org> * provide rationale for shutdown procedure Signed-off-by: William Woodall <william@osrfoundation.org> * Add launch XML substitution for a packages share directory (#254) * Add launch XML substitution for a packages share directory Rename find-pkg to find-pkg-prefix. Add find-pkg-share substitution for the share directory. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * remove some old rfc's and general cleanup for first merge Signed-off-by: William Woodall <william@osrfoundation.org>
Rename find-pkg to find-pkg-prefix.
Add find-pkg-share substitution for the share directory.
Implementation is in ros2/launch_ros#57