Skip to content

Update ROS launch documentation (frontend documents)#247

Merged
ivanpauno merged 3 commits intoroslaunchfrom
ivanpauno/roslaunch-corrections
Jul 29, 2019
Merged

Update ROS launch documentation (frontend documents)#247
ivanpauno merged 3 commits intoroslaunchfrom
ivanpauno/roslaunch-corrections

Conversation

@ivanpauno
Copy link
Copy Markdown
Member

Address some comments in #163.

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label Jul 26, 2019
@ivanpauno ivanpauno requested review from hidmic and wjwwood July 26, 2019 19:23
@ivanpauno ivanpauno self-assigned this Jul 26, 2019
@ivanpauno
Copy link
Copy Markdown
Member Author

Also, added <executable> example and renamed after ros2/launch_ros#47

Copy link
Copy Markdown

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for a couple tiny nits

Copy link
Copy Markdown
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hidmic's suggestions make sense, but otherwise lgtm

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno
Copy link
Copy Markdown
Member Author

@hidmic I've corrected #163's build problems in cb2130d (tested locally) and addressed your comments in d3e9180.

Copy link
Copy Markdown

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ivanpauno ivanpauno merged commit 3dfa8e9 into roslaunch Jul 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/roslaunch-corrections branch July 29, 2019 17:36
wjwwood added a commit that referenced this pull request Sep 18, 2019
* wip

* more work in progress

* more work done on the calling conventions section

* added context section, still a WIP

* updated event sections

* event filters

* fixup even handler subsection

* typos

* add subsections about the system description (language agnostic)

* Proposal for launching dynamically composable nodes (#206)

* Proposal for dynamically composed nodes

* allow multiple extra_arguments

* Allow node_name and namespace to be empty

* Human readable error message

* Update articles/150_roslaunch.md

Co-Authored-By: sloretz <shane.loretz@gmail.com>

* Assign nodes unique ids, but still forbid duplicates

* Update articles/150_roslaunch.md

Co-Authored-By: sloretz <shane.loretz@gmail.com>

* Update articles/150_roslaunch.md

Co-Authored-By: sloretz <shane.loretz@gmail.com>

* Section to list

* More generic wording about container processes

* namespace -> node_namespace

* _launch/ -> ~/_container/

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Propose ROS 2 launch front-end design hints. (#208)

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>

* Adds ROS 2 launch XML format design document (#207)

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>

* Update ROS launch documentation (frontend documents) (#247)

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>

* review fixup

Signed-off-by: William Woodall <william@osrfoundation.org>

* clarify lifecycle transition due to review comment

Signed-off-by: William Woodall <william@osrfoundation.org>

* provide rationale for shutdown procedure

Signed-off-by: William Woodall <william@osrfoundation.org>

* Add launch XML substitution for a packages share directory (#254)

* Add launch XML substitution for a packages share directory

Rename find-pkg to find-pkg-prefix.
Add find-pkg-share substitution for the share directory.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* remove some old rfc's and general cleanup for first merge

Signed-off-by: William Woodall <william@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in review Waiting for review (Kanban column)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants