Demo for pre and post set parameter callback support#565
Merged
clalancette merged 25 commits intorollingfrom Oct 13, 2022
Merged
Demo for pre and post set parameter callback support#565clalancette merged 25 commits intorollingfrom
clalancette merged 25 commits intorollingfrom
Conversation
jacobperron
reviewed
Jun 6, 2022
Member
jacobperron
left a comment
There was a problem hiding this comment.
I've done a first pass; thanks for adding a demo for the new feature!
audrow
reviewed
Jul 6, 2022
Member
audrow
left a comment
There was a problem hiding this comment.
The code looks alright to me, but I think the files need to be checked for formatting. You can try running ament_cpplint or ament_cppcheck on your machine.
Contributor
Author
|
@adityapande-1995 @jacobperron should we merge this now, since the rclpy and rclcpp PR's have been merged already. |
fujitatomoya
approved these changes
Oct 5, 2022
Collaborator
|
@deepanshubansal01 lgtm, can you address the conflicts? |
Contributor
Author
Will do. |
jacobperron
reviewed
Oct 5, 2022
demo_nodes_py/demo_nodes_py/parameters/set_parameters_callback.py
Outdated
Show resolved
Hide resolved
clalancette
requested changes
Oct 6, 2022
Contributor
clalancette
left a comment
There was a problem hiding this comment.
I've left a couple of stylistic points to consider.
demo_nodes_py/demo_nodes_py/parameters/set_parameters_callback.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Seems like it's good to go, should I squash and merge now? |
Contributor
We still need approval and to run CI on it. I'll take another look, though I may not get back to it today. |
Contributor
|
CI :
|
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
b94bc55 to
7078cbf
Compare
Contributor
|
CI failed here because this needed another rebase. Done now, here is CI again:
|
clalancette
approved these changes
Oct 12, 2022
Contributor
Author
|
Seems like CI is passing now. Can I squash merge now or wait for more pending reviewers. Thanks! |
clalancette
added a commit
that referenced
this pull request
Oct 13, 2022
This reverts commit 25f6176.
cardboardcode
pushed a commit
to cardboardcode/demos
that referenced
this pull request
Jan 23, 2023
* local parameter callback support Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
cardboardcode
pushed a commit
to cardboardcode/demos
that referenced
this pull request
Jan 23, 2023
* local parameter callback support Signed-off-by: deepanshu <deepanshubansal01@gmail.com> Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to ros2/rclcpp#1947 and ros2/rclpy#966
Signed-off-by: deepanshu deepanshubansal01@gmail.com