Support for pre-set and post-set parameter callback.#966
Merged
adityapande-1995 merged 23 commits intorollingfrom Jul 25, 2022
Merged
Support for pre-set and post-set parameter callback.#966adityapande-1995 merged 23 commits intorollingfrom
adityapande-1995 merged 23 commits intorollingfrom
Conversation
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
This reverts commit 999628b. Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
…allbacks Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
0570f70 to
ab800cf
Compare
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
|
Full CI : build :
|
…r CI run failure Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Contributor
Author
|
@adityapande-1995 we can try running the CI again now:) |
|
CI round 2 : build : --packages-above-and-dependencies rclpy
|
|
CI round 3 : build : --packages-above-and-dependencies rclpy
|
adityapande-1995
approved these changes
Jul 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supports adding new parameters registered callbacks namely
pre_set_parameterandpost_set_parametercallback to node API. Full description can be found in rclcpp version of the PR here ros2/rclcpp#1947Design document: https://github.com/ros2/rclcpp/blob/deepanshu/local-param-changed-callback-support/rclcpp/doc/proposed_node_parameter_callbacks.md
Demo node: ros2/demos#565
rclcpp ticket: ros2/rclcpp#1947
Related discussion: ros2/rclcpp#1190, ros2/rclcpp#609
Signed-off-by: deepanshu deepanshubansal01@gmail.com