Add python headers for python bindings#788
Add python headers for python bindings#788wjwwood merged 1 commit intoros-visualization:hydro-develfrom
Conversation
Adding ${PYTHON_INCLUDE_DIRS} to the sip python bindings.
Needed at least on OSX/10.9 to compile successfully.
Add python headers for python bindings
|
Possibly that was the wrong fix and the sip_helper should get patched instead, see ros-visualization/qt_gui_core#46 |
This fixes ros-visualization/qt_gui_core#46 and ros-visualization/rviz#788; needed at least on OS X, likely some other platforms as well.
|
You mean you think that the |
|
That may be the case, at any rate this shouldn't be a problem if the fix is done upstream too. We can try undoing it once the other issue is addressed. |
Nope. See ros-visualization/python_qt_binding#12 for a proposed change to the sip_helper to add the It shouldn't do any harm though. We could revert it, but no rush. |
|
ros-visualization/python_qt_binding#12 has been merged, so feel free to revert this any time (or not, doesn't really matter much). |
* Remove TF filter from ImageTransportDisplay Fixes ros-visualization#639 Only the CameraDisplay cares about TF data, so this change moves the TF filter logic into the CameraDisplay. This allows users to view images with the ImageDisplay no matter what the fixed frame is set to. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Adding ${PYTHON_INCLUDE_DIRS} to the sip python bindings.
Needed at least on OSX/10.9 to compile successfully.
This should maybe be also ported to groovy and indigo.