Publish TwistStamped message optionally#18
Merged
ahcorde merged 2 commits intoros-visualization:dashing-develfrom Mar 21, 2025
Merged
Publish TwistStamped message optionally#18ahcorde merged 2 commits intoros-visualization:dashing-develfrom
ahcorde merged 2 commits intoros-visualization:dashing-develfrom
Conversation
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
|
Dear maintainers, could you check this PR please? This PR would be essential to use rqt_robot_steering with ros2_control . |
ahcorde
approved these changes
Mar 21, 2025
patrik-knaperek
added a commit
to patrik-knaperek/rqt_robot_steering
that referenced
this pull request
Apr 11, 2025
- Fixed not publishing Twist message when checkbox `stamped` is unchecked - Re-added publishing zero message only once (removed by ros-visualization#18)
ahcorde
pushed a commit
that referenced
this pull request
Apr 16, 2025
- Fixed not publishing Twist message when checkbox `stamped` is unchecked - Re-added publishing zero message only once (removed by #18) Co-authored-by: Patrik Knaperek <pknaperek@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We started recently to drop the Twist messages without timestamp from ros2_control, see ros-controls/ros2_controllers#812.
This makes changes to this plugin necessary.
I saw the PR #16 from @ahcorde but just adding
_stampedto the topic name doesn't work without additional topic name remapping.Thererfore, I propose a different approach: I added a checkbox
stamped, and the plugin only selects the stamped or non-stamped topic depending on the checkbox's state.