add QtWidgets for forward compatibility with Qt5#31
Merged
dirk-thomas merged 2 commits intogroovy-develfrom Mar 31, 2016
Merged
add QtWidgets for forward compatibility with Qt5#31dirk-thomas merged 2 commits intogroovy-develfrom
dirk-thomas merged 2 commits intogroovy-develfrom
Conversation
Member
|
Seems reasonable to me. So importing |
Contributor
Author
|
In Qt 5 the modules have the default meaning. For Qt 4 |
4d0ca72 to
f71ce8e
Compare
f71ce8e to
cfc0d24
Compare
Member
|
Sounds good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will enable most Python plugins to use the same code base to support Qt 4 as well as 5 with only minimal
try / exceptfor actual differences between the versions (see e.g. ros-visualization/rqt_common_plugins#359).