Fix to allow ninja to use make for generators (#123)#128
Merged
clalancette merged 1 commit intoros-visualization:humblefrom Oct 17, 2023
Conversation
[ Upstream commit ade88c5 ] Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Co-authored-by: Chris Lalancette <clalancette@gmail.com>
clalancette
approved these changes
Oct 16, 2023
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Looks reasonable to me, thanks!
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of upstream commit ade88c5. This allows ROS Humble LTS to be compiled with Ninja.
Without this, colcon build with an environment variable
CMAKE_GENERATOR=Ninjafor packages depending onpython_qt_bindingfails with the following error.