Fix to allow ninja to use make for generators#123
Merged
Conversation
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
clalancette
reviewed
Mar 2, 2023
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Left a question inline.
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Co-authored-by: Chris Lalancette <clalancette@gmail.com>
clalancette
approved these changes
Mar 2, 2023
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me with green CI.
Contributor
Author
|
yashi
pushed a commit
to yashi/python_qt_binding
that referenced
this pull request
Sep 29, 2023
[ Upstream commit ade88c5 ] Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Co-authored-by: Chris Lalancette <clalancette@gmail.com>
clalancette
added a commit
that referenced
this pull request
Oct 17, 2023
|
Could I ask for this to be backported to Noetic? It prevents me from building RViz with ninja: #111 (comment) . |
jprestwo
pushed a commit
to locusrobotics/python_qt_binding
that referenced
this pull request
Feb 17, 2026
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Co-authored-by: Chris Lalancette <clalancette@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue when building
qt_gui_cppwithninja, and it is traced back topython_qt_binding.This allows ninja to find the make executable and use it for this particular step. The alternative would be to make the generator create ninja-files in addition to makefiles, but that seems like more work, given that
makeshould be available on all platforms.