add image_flip node#942
Merged
ahcorde merged 4 commits intoros-perception:rollingfrom Dec 11, 2024
mikeferguson:rolling-image-flip
Merged
add image_flip node#942ahcorde merged 4 commits intoros-perception:rollingfrom mikeferguson:rolling-image-flip
ahcorde merged 4 commits intoros-perception:rollingfrom
mikeferguson:rolling-image-flip
Conversation
Member
Author
|
After reviewing this closer - I may also make both nodes derive from a base class to avoid so much duplicated code |
ahcorde
requested changes
Aug 20, 2024
Contributor
ahcorde
left a comment
There was a problem hiding this comment.
is this PR still relevant ? there are some conflicts
Contributor
|
@mikeferguson ready for review ? |
Member
Author
Yes, I was originally planning to try and merge the two nodes... but, yeah, that turns out to be messier than I thought. |
ahcorde
approved these changes
Dec 11, 2024
Contributor
|
@mikeferguson do you want to backport this PR ? |
Member
Author
|
https://github.com/Mergifyio backport jazzy |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
This is a continuation of #756: * [x] Squashed 16 commits in original PR for ease of rebase/review * [x] Moved node into image_rotate package * [x] Added lazy subscriber * [x] Removes QoS parameters - will add proper QoS overrides in a different PR (when we do the same for image_rotate) * [x] Adds documentation --------- Co-authored-by: David Conner <robotics@cnu.edu> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit c8622e7)
5 tasks
ahcorde
pushed a commit
that referenced
this pull request
Dec 11, 2024
This is a continuation of #756: * [x] Squashed 16 commits in original PR for ease of rebase/review * [x] Moved node into image_rotate package * [x] Added lazy subscriber * [x] Removes QoS parameters - will add proper QoS overrides in a different PR (when we do the same for image_rotate) * [x] Adds documentation<hr>This is an automatic backport of pull request #942 done by [Mergify](https://mergify.com). Co-authored-by: Michael Ferguson <mfergs7@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #756: