Image transport tutorial#197
Merged
mjcarroll merged 14 commits intoros-perception:ros2from Jul 29, 2021
Merged
Conversation
Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
Contributor
Author
|
Pinging @jacobperron and @mjcarroll for review |
jacobperron
reviewed
Jul 7, 2021
Contributor
jacobperron
left a comment
There was a problem hiding this comment.
Nice, I like the tutorial as it's own package 👍
Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
mjcarroll
approved these changes
Jul 14, 2021
Contributor
mjcarroll
left a comment
There was a problem hiding this comment.
LGTM, I'm trying to get a few other PRs in then I will land this one.
Contributor
|
@mjcarroll Friendly ping |
Contributor
|
This one got merged without CI, and is causing havoc all over the place (every single build on https://ci.ros2.org/view/nightly/ is broken). I'm going to open a revert PR for now and we'll have to deal with it separately. |
clalancette
added a commit
that referenced
this pull request
Aug 2, 2021
This reverts commit 8cef3db.
clalancette
added a commit
that referenced
this pull request
Aug 2, 2021
This was referenced Aug 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #193
This PR ports the existing
image_transporttutorials from ROS 1 to ROS 2.The tutorial code now lives in a dedicated
image_transport_tutorialpackage. The content from http://wiki.ros.org/image_transport/Tutorials is presented in the README and has been updated to work for ROS 2.