Skip to content

Revert "Image transport tutorial (#197)"#203

Merged
clalancette merged 1 commit intoros2from
revert-tutorial
Aug 2, 2021
Merged

Revert "Image transport tutorial (#197)"#203
clalancette merged 1 commit intoros2from
revert-tutorial

Conversation

@clalancette
Copy link
Copy Markdown
Contributor

This reverts commit 8cef3db.

@clalancette clalancette requested a review from mjcarroll August 2, 2021 13:06
@clalancette
Copy link
Copy Markdown
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Copy Markdown
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's on me. I thought I saw CI, merged too quickly.

@Ace314159
Copy link
Copy Markdown
Contributor

Btw, I made #200 that fixes the build, which we've tested on Windows and Mac OS. Instead of reverting, would it be better to merge my fix instead?

@clalancette
Copy link
Copy Markdown
Contributor Author

Btw, I made #200 that fixes the build, which we've tested on Windows and Mac OS. Instead of reverting, would it be better to merge my fix instead?

Unfortunately, that is not enough. The basic problem is that cv_bridge isn't available in our CI right now, and so this fails to compile on all platforms. We'll have to consider that as well as your fix once we try to get the PR back in.

@jacobperron
Copy link
Copy Markdown
Contributor

jacobperron commented Aug 9, 2021

After an offline discussion we'll move the tutorials package to its own repo: https://github.com/ros-perception/image_transport_tutorials

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants