Skip to content

remove LifecycleNode's argument use_rclcpp_node#2993

Merged
SteveMacenski merged 2 commits intoros-navigation:mainfrom
gezp:remove_rclcpp_node_in_lifecycle_node
Jun 2, 2022
Merged

remove LifecycleNode's argument use_rclcpp_node#2993
SteveMacenski merged 2 commits intoros-navigation:mainfrom
gezp:remove_rclcpp_node_in_lifecycle_node

Conversation

@gezp
Copy link
Contributor

@gezp gezp commented Jun 2, 2022 •
edited
Loading

Signed-off-by: zhenpeng ge zhenpeng.ge@qq.com

Basic Info

Info Please fill out this column
Ticket(s) this addresses (tickets: #816)
Primary OS tested on (Ubuntu)
Robotic platform tested on (gazebo simulation of turtlebot3)

Description of contribution in a few bullet points

this is a final PR to solve #816

  • remove LifecycleNode's argument use_rclcpp_node and member rclcpp_node_ which is unused currently.
  • update the construction function of some nodes which derived from LifecycleNode.
  • update test_costmap_topic_collision_checker.cpp which use rclcpp_node_ (like Reduce costmap_2d_ros nodes #2489).

Description of documentation updates required from your changes

update migration documentation : ros-navigation/docs.nav2.org#321

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@gezp
remove LifecycleNode's argument use_rclcpp_node
5fee498 
Signed-off-by: zhenpeng ge <zhenpeng.ge@qq.com>
@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2022

@gezp, please properly fill in PR template in the future. @SteveMacenski, use this instead.

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@gezp gezp mentioned this pull request Jun 2, 2022
Closed
@gezp
update comment
21d1df4 
Signed-off-by: zhenpeng ge <zhenpeng.ge@qq.com>
@SteveMacenski SteveMacenski merged commit 30048b4 into ros-navigation:main Jun 2, 2022
redvinaa pushed a commit to EnjoyRobotics/navigation2 that referenced this pull request Jun 30, 2022
@gezp @redvinaa
remove LifecycleNode's argument use_rclcpp_node (ros-navigation#2993)
7c256d5 
* remove LifecycleNode's argument use_rclcpp_node

Signed-off-by: zhenpeng ge <zhenpeng.ge@qq.com>

* update comment

Signed-off-by: zhenpeng ge <zhenpeng.ge@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gezp @SteveMacenski