Simplifying CMakelists to use the standard test suite.#29
Merged
2 commits merged intomasterfrom Sep 7, 2018
unknown repository
Merged
Simplifying CMakelists to use the standard test suite.#292 commits merged intomasterfrom unknown repository
2 commits merged intomasterfrom
unknown repository
Conversation
Author
|
Now that the other PRs are integrated, this one can go in now. Please review when you have a chance. |
Collaborator
|
@crdelsey - does this need to be rebased again now that ros2_devel has been merged? |
Author
|
Code is rebased and ready for review again |
mkhansenbot
approved these changes
Sep 7, 2018
Collaborator
mkhansenbot
left a comment
There was a problem hiding this comment.
Looks good to me but will need to be rebased and there's a conflict with the AMCL PR that was merged earlier today that needs to be resolved. Should be just a few lines and you can resolve it during merge.
SteveMacenski
added a commit
that referenced
this pull request
Aug 20, 2020
* adding last local changes * prams
ghost
referenced
this pull request
in logivations/navigation2
Mar 7, 2022
…fter previous failure (#29) * probable fix * reverting logic * close goal fix * added handling for "no valid path" cases * added requested changes
doisyg
added a commit
to doisyg/navigation2
that referenced
this pull request
Mar 21, 2024
…ther_sync AUTO-1589 Minimal nav2 update
mini-1235
pushed a commit
to mini-1235/navigation2
that referenced
this pull request
Feb 5, 2025
The parameter ``bt_xml_filename`` has changed to ``default_bt_xml_filename``
Forsyth-Creations
pushed a commit
to Forsyth-Creations/navigation2
that referenced
this pull request
Feb 19, 2025
* Fix windows warning Signed-off-by: Anas Abou Allaban <aabouallaban@pm.me> * Fix remaining warnings Signed-off-by: Anas Abou Allaban <aabouallaban@pm.me>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a an existing set of ament packages that perform all the standard tests (eg uncrustify, cppcheck, etc) automatically.
Updating the code to use this new version.
I'll wait on starting a review until after I rebase from some of the other PRs that are about to go in.