Add 'angles' dependency to nav2_costmap_2d package.xml#1947
Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom Aug 17, 2020
Merged
Add 'angles' dependency to nav2_costmap_2d package.xml#1947SteveMacenski merged 1 commit intoros-navigation:mainfrom
SteveMacenski merged 1 commit intoros-navigation:mainfrom
Conversation
SteveMacenski
approved these changes
Aug 17, 2020
Member
SteveMacenski
left a comment
There was a problem hiding this comment.
Damn those build farm changes. Thanks, I have 0 idea how I missed that this was failing.
Contributor
|
@SteveMacenski Foxy builds have been failing since August 11th: http://build.ros2.org/view/Fbin_uF64/job/Fbin_uF64__nav2_costmap_2d__ubuntu_focal_amd64__binary/ It would be good to get this patch released for Foxy to fix the regression. I'd like to do a Foxy sync this week. |
Member
|
I've been waiting until the notice of a Foxy sync to get as much stuff in the new sync as possible. Did you announce the pending sync? I must have missed it. |
Contributor
|
I'm about to announce it, just checking on the regression status and noticed this one. |
SteveMacenski
pushed a commit
that referenced
this pull request
Aug 24, 2020
SteveMacenski
added a commit
that referenced
this pull request
Aug 24, 2020
* waypoint_follower node has _rclcpp_node as well as base node (#1940) * Add #include <vector> for vector<> (#1946) To fix cpplint * Add 'angles' dependency to nav2_costmap_2d package.xml (#1947) * transform goal to costmap frame (#1949) The plan recieved is usually in global frame, but our local costmap is often in odom frame. This fixes a regression from #1857 * Add mutex lock into inflation layer to avoid thread issue in updating footprint (#1952) Signed-off-by: Daisuke Sato <daisukes@cmu.edu> * Fix being unable to change StandardTrajectoryGenerator parameter vtheta_samples (#1619) * Fix tests declaring parameters real nodes don't Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Fix loadParameterWithDeprecation not getting initial parameter values Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Create sim_time variable before using it Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Line length < 100 Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Add missing { Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Linter fixes Signed-off-by: Shane Loretz <sloretz@openrobotics.org> * sim_granularity -> time_granularity Signed-off-by: Shane Loretz <sloretz@openrobotics.org> * Linter fix Signed-off-by: Shane Loretz <sloretz@openrobotics.org> * update version to 0.4.3 * removing redundant dep on angles Co-authored-by: Ruffin <roxfoxpox@gmail.com> Co-authored-by: Sarthak Mittal <sarthakmittal2608@gmail.com> Co-authored-by: Michael Ferguson <mfergs7@gmail.com> Co-authored-by: Daisuke Sato <43101027+daisukes@users.noreply.github.com> Co-authored-by: Shane Loretz <sloretz@openrobotics.org>
ruffsl
pushed a commit
to ruffsl/navigation2
that referenced
this pull request
Jul 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
nav2_costmap_2dpackage.xml to fix failing foxy debian builds