clarify CATKIN_IGNORE may be a file, directory, or (dangling) symlink#256
clarify CATKIN_IGNORE may be a file, directory, or (dangling) symlink#256dirk-thomas merged 3 commits intoros-infrastructure:masterfrom
Conversation
Mention that CATKIN_IGNORE may be any type of file
change "are ignored" to "don't matter" to avoid implying that that's what "IGNORE" is referring to in "CATKIN_IGNORE"
dirk-thomas
left a comment
There was a problem hiding this comment.
Beside the inline question please update the title of the PR since it will become the commit message.
dirk-thomas
left a comment
There was a problem hiding this comment.
Widening the possible types for the marker sounds reasonable to me. I don't expect any breakage being introduced due to this change (like users have directories or (dangling) symlinks with this name but not intending to ignore the path).
|
@ros-infrastructure/ros_team Please review and approve this proposed change. |
mjcarroll
left a comment
There was a problem hiding this comment.
I don't see anything wrong with this, but I am curious how you use it in practice? Is there a benefit to making the marker files a directory or symlink?
Answered my own question: ros-infrastructure/catkin_pkg#286 (comment) |
|
3 👍 and 5 days sounds like enough to me. Merging... |
* Allow ignore_marker to be a dangling symlink As per ros-infrastructure/rep#256 * os.path.lexists instead of (nonexistent) pathlib.path.lexists
* Respect ignore marker even if dangling symlink As per ros-infrastructure/rep#256 * os.path.lexists instead of (nonexistent) pathlib.path.lexists Co-authored-by: Prajakta Gokhale <prajaktg@amazon.com>
Mention that CATKIN_IGNORE may be any type of file and its contents are ignored