Respect ignore marker even if dangling symlink#164
Merged
prajakta-gokhale merged 4 commits intocolcon:masterfrom May 13, 2020
Merged
Respect ignore marker even if dangling symlink#164prajakta-gokhale merged 4 commits intocolcon:masterfrom
prajakta-gokhale merged 4 commits intocolcon:masterfrom
Conversation
Member
|
Have you tried running the patch? |
Contributor
Author
I hadn't, as can be seen from CI! |
Contributor
Author
|
This patch now works correctly and is ready for review |
Member
|
With the REP update merged (ros-infrastructure/rep#256) this can be merged whenever the maintainers are ready. |
piraka9011
approved these changes
May 13, 2020
prajakta-gokhale
approved these changes
May 13, 2020
murphm8
approved these changes
May 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per ros-infrastructure/rep#256