Skip to content

[JTC] Continue with last trajectory-point on success#842

Merged
bmagyar merged 5 commits intoros-controls:masterfrom
christophfroehlich:jtc/continue_success
Dec 1, 2023
Merged

[JTC] Continue with last trajectory-point on success#842
bmagyar merged 5 commits intoros-controls:masterfrom
christophfroehlich:jtc/continue_success

Conversation

@christophfroehlich
Copy link
Copy Markdown
Member

@christophfroehlich christophfroehlich commented Nov 16, 2023

As discussed in #811: Continue with last trajectory point on success, instead of hold-position from current state.

Closes #811 and closes #759.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 17, 2023

Codecov Report

Merging #842 (5d8142f) into master (3555685) will decrease coverage by 0.45%.
Report is 1 commits behind head on master.
The diff coverage is 33.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
- Coverage   47.22%   46.77%   -0.45%     
==========================================
  Files          40       40              
  Lines        3636     3641       +5     
  Branches     1716     1719       +3     
==========================================
- Hits         1717     1703      -14     
- Misses        735      749      +14     
- Partials     1184     1189       +5     
Flag Coverage Δ
unittests 46.77% <33.33%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...jectory_controller/joint_trajectory_controller.hpp 0.00% <ø> (ø)
...ory_controller/src/joint_trajectory_controller.cpp 48.89% <33.33%> (+0.91%) ⬆️

... and 2 files with indirect coverage changes

@bmagyar bmagyar merged commit e4f1700 into ros-controls:master Dec 1, 2023
mergify bot pushed a commit that referenced this pull request Dec 1, 2023
@christophfroehlich christophfroehlich deleted the jtc/continue_success branch December 1, 2023 14:00
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Dec 1, 2023
christophfroehlich added a commit that referenced this pull request Dec 4, 2023
christophfroehlich added a commit that referenced this pull request Dec 5, 2023
christophfroehlich added a commit that referenced this pull request Dec 5, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Dec 5, 2023
christophfroehlich added a commit that referenced this pull request Dec 9, 2023
christophfroehlich added a commit that referenced this pull request Jan 2, 2024
christophfroehlich added a commit that referenced this pull request Jan 12, 2024
christophfroehlich added a commit that referenced this pull request Feb 17, 2024
christophfroehlich added a commit that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JTC] Send feedback for action only once [JTC] set_hold_position results into not exactly reaching desired target

2 participants