[JTC] Continue with last trajectory-point on success (backport #842)#877
Merged
[JTC] Continue with last trajectory-point on success (backport #842)#877
Conversation
f677a4c to
c24ad23
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## iron #877 +/- ##
==========================================
+ Coverage 72.72% 72.76% +0.03%
==========================================
Files 40 40
Lines 3505 3510 +5
Branches 1750 1753 +3
==========================================
+ Hits 2549 2554 +5
Misses 659 659
Partials 297 297
Flags with carried forward coverage won't be shown. Click here to find out more.
|
04ad4ca to
7e3327c
Compare
7e3327c to
0664f2e
Compare
0664f2e to
df58964
Compare
df58964 to
02fad28
Compare
Member
|
maybe asking the obvious but I think this behaviour change would not be too welcome in Iron at this point... perhaps a flag? |
Member
From the feedback we got on rolling, the "old" behavior (stopping at the position at the time of reaching the tolerances) was not desired, which means that this PR is more kind of a bug-fix. |
(cherry picked from commit e4f1700)
02fad28 to
cff51a6
Compare
bmagyar
approved these changes
Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #842 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com